Add geometry of selected BigCZ result to map #2213
Conversation
caseycesari
force-pushed
the
cpc/add-selected-result-geom
branch
from
9695c04
to
b596fe9
Compare
|
@azavea-bot rebuild |
There was a problem hiding this comment.
This works great for WDC. For CINERGI, if I select a result whose AoI is bigger than my viewport, I get the blue outline. But then, if I zoom out, I never get the actual shape, and only ever get the blue outline. Similarly, if I select a shape and then zoom in to it, instead of getting the blue outline when I'm too close, I get the blue overlay.
Can we add a zoom / pan handler to the map that updates this for the active shape when in the details view?
src/mmw/js/src/core/views.js
Outdated
| @@ -206,7 +216,8 @@ var MapView = Marionette.ItemView.extend({ | |||
| 'change:size': 'toggleMapSize', | |||
| 'change:maskLayerApplied': 'toggleMask', | |||
| 'change:dataCatalogResults': 'renderDataCatalogResults', | |||
| 'change:dataCatalogActiveResult': 'renderDataCatalogActiveResult', | |||
| 'change:dataCatalogActiveResult': 'renderDataCatalogResult', | |||
| 'change:dataCatalogDetailResult': 'renderDataCatalogResult', | |||
There was a problem hiding this comment.
Since they both trigger the same function, consider putting them in one line:
'change:dataCatalogActiveResult change:dataCatalogDetailResult': 'renderDataCatalogResult',otherwise it seems like there is a mistake in the first one, where the left and right side don't match.
There was a problem hiding this comment.
Unfortunately, condensing them into one line modifies the shape of the event object. The changed attribute is no longer included in the event payload, which prevents the event handler from detecting which attribute is changing.
otherwise it seems like there is a mistake in the first one, where the left and right side don't match.
I'm not sure I understand. Can you elaborate?
src/mmw/js/src/data_catalog/views.js
Outdated
| } else { | ||
| this.detailsRegion.show(new ResultDetailsView({ | ||
| model: detailResult, | ||
| activeCatalog: activeCatalog.id | ||
| })); | ||
| App.map.set('dataCatalogActiveResult', detailResult.get('geom')); | ||
| App.map.set('dataCatalogResults', null); | ||
| App.map.set('dataCatalogDetailResult', detailResult.get('geom')); |
There was a problem hiding this comment.
Consider combining these into one set:
App.map.set({
dataCatalogResults: null,
dataCatalogDetailResult: detailResult.get('geom'),
});
|
Pushed a couple fixup commits to address the feedback. Demo:
|
When a user views the details of a BigCZ result, the geometry of the selected result is highlighted on the map, and all of the other items on the map are removed. Refs #2152
caseycesari
force-pushed
the
cpc/add-selected-result-geom
branch
from
5d04ff5
to
152a668
Compare
Overview
When a user views the details of a BigCZ result, the geometry of the
selected result is highlighted on the map, and all of the other items
on the map are removed.
Connects #2152
Demo
Notes
I initially tried using the same layer group as the highlight layer, but because of the way the events are wired up for that layer, I wasn't able to do it. The
mouseoutevent of the result item in the list would fire when the user moves the mouse over detail pane, and the highlight would be cleared.Marker styling was based on the wireframes: https://marvelapp.com/5a66caa/screen/29866795
Testing Instructions