Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: show model details popover tooltip for new projects #2223

Merged
merged 1 commit into from
Sep 6, 2017

Conversation

arottersman
Copy link

Overview

There was a bug in the recent work done for #1366 where the model description tooltip wouldn't appear if the project was new.

screen shot 2017-09-06 at 9 10 49 am

Connects #1366

Testing Instructions

  • Draw an aoi and select a model. Confirm you can click the tooltip next to the model name and see the model description
  • Load a saved project and do the same

* binding the model description tooltip in the model details popover wasn't
  happening for new projects. Bind the tooltip in onRender, instead of onShow
Copy link
Contributor

@kellyi kellyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Tested in Chrome, FF, Safari, and IE11 & it's working correctly in each.

@kellyi kellyi assigned arottersman and unassigned kellyi Sep 6, 2017
@arottersman
Copy link
Author

Thanks!

@arottersman arottersman merged commit f56e247 into develop Sep 6, 2017
@arottersman arottersman deleted the arr/fix-aoi-detail-popup branch September 6, 2017 17:14
@rajadain rajadain mentioned this pull request Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants