Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WKAoI field to Project Model #2244

Merged
merged 2 commits into from
Sep 12, 2017
Merged

Conversation

rajadain
Copy link
Member

@rajadain rajadain commented Sep 8, 2017

Overview

Adds WKAoI field to project model, so when using a predefined boundary, that boundary's id is now saved to the project. Thus, when the project is reloaded at a later date, the user can still benefit from the cached results by specifying the WKAoI id. Previously, since this id was not available, reloaded used projects would trigger unnecessary fresh bouts of geoprocessing.

Connects #1899

Demo

2017-09-08 13 36 00

Testing Instructions

  • On develop, log in to MMW and create and save a TR-55 and a MapShed project with well-known boundaries (HUC-12s)
  • Check out this branch, and run manage migrate and bundle
  • Create and save a new TR-55 project using a HUC-12. Ensure that the Analyze and TR-55 requests use WKAoI when they start their run.
  • Reload the saved TR-55 project, and ensure that this also uses the saved WKAoI.
  • Do the same for MapShed.
  • Test the TR-55 and MapShed projects created before this branch. Ensure that while they don't use WKAoI, they otherwise work correctly and just as before.
  • Ensure there are no errors in the console.

This field will save the well-known area of interest (if
available), so that when the project is reloaded, the
geoprocessing tasks can be run using that wkaoi and take
advantage of caching.
Since now the WKAoI field is saved in the model, we need to
update the map's wellKnownAreaOfInterest field accordingly.
In addition, since the AnalyzeCollection is tailored to a
specific AoI on creation, when exiting the Modeling view we
destroy it, so that it may be made again with the correct
WKAoI (if any).
Copy link

@arottersman arottersman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, tested. Develop projects are still working, and new ones use wkaoi.

@arottersman arottersman assigned rajadain and unassigned arottersman Sep 12, 2017
@rajadain rajadain merged commit 1f96784 into develop Sep 12, 2017
@rajadain rajadain deleted the tt/add-wkaoi-to-project-model branch September 12, 2017 16:49
@rajadain
Copy link
Member Author

Thanks for taking a look!

@rajadain rajadain mentioned this pull request Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants