Calculate SedNitr value from SoilN raster #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calculates the average SoilN value for a given area of interest and multiplies it by 4.0 to get the SedNitr value. This was previously staticly set at 2000.
kellyi
reviewed
Sep 15, 2017
|
|
||
| Originally a static value of 2000 at Class1.vb@1.3.0:9587 | ||
| """ | ||
| if 'error' in sjs_result: |
There was a problem hiding this comment.
Wonder when it would make sense to rename sjs_result -> geoprocessing_result.
There was a problem hiding this comment.
Is it just this file that refers to it as such? I'd be happy to include a rename commit while working on the other two cards in this family.
There was a problem hiding this comment.
I'll add a lint commit to this PR that changes all of them. Good catch.
arottersman
approved these changes
Sep 15, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Calculates the average SoilN value for a given area of interest
and multiplies it by 4.0 to get the SedNitr value. This was
previously staticly set at 2000.
Connects #1754
Demo
Here is the GMS file produced on this branch: MapShed_SoilN.gms.txt
As can be seen on line 37 position 1, the value is not 2000:
The value of 1004 is for a square kilometer AoI in Center City Philadelphia.
Notes
I imagine that the value of 2000 is typical of agricultural land use heavy areas of interest, so a value of ~1000 for a city sounds reasonable. For an area of interest with most land use in the categories of Cultivated Crops and Pasture / Hay, we are more likely to get a higher value.
Testing Instructions
vagrant ssh worker -c 'sudo service celeryd restart'