Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Catchment Popup #2364

Merged
merged 1 commit into from
Oct 12, 2017
Merged

Fix Catchment Popup #2364

merged 1 commit into from
Oct 12, 2017

Conversation

arottersman
Copy link

@arottersman arottersman commented Oct 11, 2017

Overview

  • We were failing to display the water quality catchment
    popup when you click a row in the analyze water quality
    table

  • We were still treating the water quality geom as string,
    but it now comes as a regular json object and doesn't
    need to be parsed

Connects #2361

Demo

screen shot 2017-10-11 at 6 20 21 pm

Testing Instructions

Analayze some AoI and confirm you can see the popups when you click one of the Water Quality table rows in analzye.

* We were failing to display the water quality catchment
  popup when you clicked a row in the analyze water quality
  table

* We were still treating the water quality geom as string,
  but it now comes as a regular json object and doesn't
  need to be parsed
Copy link
Contributor

@mmcfarland mmcfarland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@kellyi kellyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kellyi kellyi assigned arottersman and unassigned kellyi Oct 12, 2017
@arottersman arottersman merged commit 307a37d into release/1.20.0 Oct 12, 2017
@arottersman arottersman deleted the arr/fix-catchment-popup branch October 12, 2017 14:04
@rajadain rajadain mentioned this pull request Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants