BiG-CZ: Increase Area of Interest Size #2418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the area of interest is larger than 1500 sq km, the number of results can be too large to be processed by suds within the resources of the App VM. To compensate for this, we restrict searches to be within 5 years by default in these cases, which is in most cases enough.
For larger areas of interest, this call returns a very large number of results, serializing all of which is futile and expensive.
rajadain
force-pushed
the
tt+ki/bigcz-increase-analyze-size
branch
from
cc71fa1
to
76e0eca
Compare
|
We're probably going to reconsider this, so I'm pulling all review requests and closing this PR without merging for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Increases size of area of interest to 8000. Limits BiG-CZ searches to the last five years by default whenever area of interest is bigger than 1500 km².
The commit 76e0eca alleviates a CPU and RAM utilization issue where a large number of CUAHSI results would fail to serialize to JSON in order to cache. Now we don't cache the CUAHSI results. However,
sudsitself chokes at a certain point (around 800 or so results). Thus the time limit.Builds on top of #2409
Connects #2388
Notes
Should we consider adding some sort of message that explains this behavior to the user?
Testing Instructions