Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Climate Analyze tab to MMW #2517

Merged
merged 1 commit into from
Nov 17, 2017
Merged

Conversation

rajadain
Copy link
Member

Overview

Previously the Climate Analyze tab was only available to BiG-CZ. Now we make it common to both MMW and BiG-CZ.

Connects #2515

Demo

MMW

image

BiG-CZ

image

Testing Instructions

  • Check out this branch and bundle
  • Go to :8000/?bigcz and select a shape to analyze. Ensure you see the Climate tab.
  • Go to :8000/ and select a shape to analyze. Ensure you see the Climate tab.
  • Ensure there is enough space for all the analyze tab headers.
  • Try a large, uncached area of interest. Ensure that Analyze completes for all tabs successfully.

Previously the Climate Analyze tab was only available
to BiG-CZ. Now we make it common to both MMW and BiG-CZ.
@arottersman
Copy link

Taking a look now

Copy link

@arottersman arottersman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, see Climate on both MMW and BiG-CZ.

We'll have to look at how we're creating the rendered layer list at some point — I'm not sure we'll want climate as one of the first three layers.

@arottersman arottersman assigned rajadain and unassigned arottersman Nov 17, 2017
@arottersman
Copy link

Just did a few more bigger shapes. Schuykill timed out the first time but succeeded the second. at some point, we'll definitely want to defer some of these start requests until the user selects the tab.

@rajadain rajadain merged commit c9f899a into develop Nov 17, 2017
@rajadain rajadain deleted the tt/make-climate-analyze-common branch November 17, 2017 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants