Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branding Updates #2593

Merged
merged 5 commits into from
Jan 5, 2018
Merged

Branding Updates #2593

merged 5 commits into from
Jan 5, 2018

Conversation

rajadain
Copy link
Member

@rajadain rajadain commented Jan 4, 2018

Overview

Updates Model My Watershed splash page branding as follows:

  • Removes all the sponsor information from the sidebar
  • Turns the About button into a modal launcher instead of a hyperlink. This About modal has text and images of the sponsors.
  • Add a Help button that links to the help page.
  • Add Stroud logo to the center of the app header
  • Adjust code so that none of this affects BiG-CZ

Tagging @caseycesari for code review, and @jfrankl and @ajrobbins for visual review.

Connects #2534

Demo

Home / Splash page:

image

About Modal:

image

BiG-CZ Splash page:

image

Notes

  • Do we add Stroud to the "With major funding from" section?
  • The WikiWatershed logo is now completely gone. Is that what we want?
  • Version number exists as a placeholder. Actual version will be added in Add MMW Version to About Modal #2591. The "Release Notes" link currently points to the "latest" tag in GitHub, but once we have the version number we will point to the specified tag.

Testing Instructions

  • Check out this branch and bundle
  • Go to :8000/ and ensure the page matches the content specified in Branding and link updates #2534
  • Try out the links in the About modal and ensure they all go to sensible places
  • Go to :8000/?bigcz and ensure that it looks exactly like the currently deployed version in production.

Instead of a link, the About button in the header now opens up
a modal showing details and links.
BiG-CZ presentation should not change, so we flag all changes
to only apply for MMW.
Copy link

@ajrobbins ajrobbins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me visually. Stroud is not itself a funder, so it doesn't belong in that section. I'm hoping we're OK without the wikiwatershed logo.

Copy link
Member

@caseycesari caseycesari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested that the change is only visible on MMW and not BIGCZ.

@caseycesari caseycesari assigned rajadain and unassigned caseycesari Jan 5, 2018
@rajadain
Copy link
Member Author

rajadain commented Jan 5, 2018

Thanks for reviewing! Merging now.

@rajadain rajadain merged commit a02c176 into develop Jan 5, 2018
@rajadain rajadain deleted the tt/branding-updates branch January 5, 2018 20:29
@jfrankl
Copy link
Contributor

jfrankl commented Jan 5, 2018

LGTM. There's a link to WikiWatershed in the about modal. I think that's a good balance for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants