HydroShare Export Handle Timeout #2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a timeout would cause an exception, breaking the flow of JavaScript on the front-end. By checking if result.responseJSON exists before calling it, we ensure that this doesn't happen. Furthermore, if we get a 504 response, we use a specific error message to communicate the timeout.
Previously we would always export all files coming from the front-end. However, this is really slow and leads to frequent timeouts on the front-end. To alleviate this, we check if the analyze files have been exported already. If so, we exclude them. This allows for the possibility of a partial analyze export (say, if the streams tab was still loading while exporting) to be completed at a later time if it becomes available, but any existing analyses are unlikely to have changed, since they depend only on the area of interest (and app config).
arottersman
approved these changes
Jan 23, 2018
|
Thanks for the quick review! Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Prevents front-end crash from HydroShare export timeouts. Also shortens re-export time by skipping pre-exported analyses.
Connects #2615
Testing Instructions
develop, export a MapShed project to HydroShare. Then add a scenario / make a change. Observe the network tab and the console, and see the timeout and JavaScript error.