Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Monitor Tab #2632

Merged
merged 3 commits into from
Feb 1, 2018
Merged

Add Monitor Tab #2632

merged 3 commits into from
Feb 1, 2018

Commits on Jan 31, 2018

  1. Centralize Data Catalog Collection init

    Previously the data catalog collection would be initialized
    in the data catalog controller, which was appropriate since
    that was the only place it would be used.
    
    However, since now we'll need to use it in at least one more
    place, namely the upcoming Monitor tab, we move it to App,
    using the same pattern as for Analyze Collection.
    
    This is a pure refactor, and does not affect BiG-CZ behavior
    at all.
    rajadain committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    e11aa5d View commit details
    Browse the repository at this point in the history
  2. Add Tabs to Analyze

    Adds a tab selection header to the top of the analyze sidebar,
    and a placeholder for where the monitor contents will go.
    
    Adjusts styling to better match the mockup by making the top
    tab bar grey and everything else white, and accounts for it
    when calculating the tab content height so that scrolling
    works correctly.
    rajadain committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    607e8c8 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2018

  1. Add basic Monitor tab

    This matches the mockup and demos the tab switching correctly.
    It currently has no behavior.
    
    In order to not affect BiG-CZ, it is better to create a new
    set of views under /monitor rather than reuse and change the
    ones under /data_catalog. We will use the same models though,
    and much of the functionality will be copied over, so it is
    not going to be a completely new effort.
    
    All the styling uses flexbox.
    rajadain committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    669c405 View commit details
    Browse the repository at this point in the history