-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monitor: Add BiG-CZ Search #2663
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To minimize duplication of effort, we are going to reuse the Data Catalog views in the Monitor tab, and edit styling until they match the mock-up. Once they do, we will adjust BiG-CZ workflow accordingly.
f016cdf
to
fbd9f8a
Compare
Taking a look now! |
Still working on the IE issue. |
arottersman
approved these changes
Feb 21, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfection on all browsers.
Turn off Monitor map contents and filer sidebar when switching to Analyze. Turn map contents back on when switching to Monitor. Also turn filter sidebar off when opening detail results.
Previously they were only enabled for BiG-CZ. Now, since the data catalog results are also visible on MMW, we enable them in all cases. This adds a map-highlight border around the map when the search result is not contained within the map. Also fixes #2336 by not removing the detail highlight when removing the active highlight.
When going from Analyze to Draw, clear data catalog results. When going from Analyze to Model, clear map items.
Since now we're using the Data Catalog views and templates directly, these files are no longer used or needed.
Not quite sure why these work, but these removals make the tab headers show up correctly, and the search form spread out to the fullness of the container, in IE11. Furthermore, they do not change the appearance or behavior in any other browser, so we seem to be safe.
31eac4d
to
0667bd9
Compare
Thanks for the thorough review! Squashed fixups, will merge once green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds the BiG-CZ search functionality to the Monitor tab, and styles it according to the mockups. Harmonizes behavior with rest of MMW, so that switching between Analyze and Monitor, going from Analyze / Monitor to Draw, and to Model, behaves as expected.
The Model stage currently does not have the Monitor tab. That will be added in #2621.
These upgrades break BiG-CZ. That will be fixed in #2639.
Connects #2622
Demo
Overview
Analyze Tab
Monitor Tab (with search results)
Monitor Tab (with filter sidebar)
Monitor Tab (with detail view)
Tagging @ajrobbins and @jfrankl for visual review.
Notes
The screen capture software I use slows down the browser. In reality the interactions are faster than the ones seen above.
There were no mockups for the filter sidebar, so I made it fit as best as I could, but we may need to create a follow up card for design tweaks there.
Should there be a spinner under the Analyze and Monitor tab headers when they are loading?
Testing Instructions
bundle