Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hydroshare resource link in safari #2698

Merged
merged 1 commit into from Mar 5, 2018
Merged

Fix hydroshare resource link in safari #2698

merged 1 commit into from Mar 5, 2018

Conversation

arottersman
Copy link

@arottersman arottersman commented Mar 2, 2018 •
edited

Hydroshare link was downloading in safari instead of opening in a new tab. We had target="_blank" but no rel="noreferrer noopener"

screen shot 2018-03-02 at 4 51 18 pm

screen shot 2018-03-02 at 4 51 37 pm

Connects #2692

Testing Instructions

  • Create a hydroshare-shared project and open the share modal in safari. Confirm clicking the link to the resource opens it in hydroshare.

Fix hydroshare resource link in safari
ace172c 
We had `target="_blank" but no `rel="noreferrer noopener"`
@arottersman arottersman requested a review from kellyi March 2, 2018 21:52
rajadain
rajadain approved these changes Mar 2, 2018
View reviewed changes
Copy link
Member

@rajadain rajadain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 tested in Safari, Google Chrome, and Firefox on Mac; IE11, Google Chrome, and Firefox on Windows. Link opens in new tab for all browsers.

@arottersman arottersman removed the request for review from kellyi March 5, 2018 14:52
@arottersman arottersman assigned arottersman and unassigned kellyi Mar 5, 2018
@arottersman
Copy link
Author

Thanks! Going to merge

@arottersman arottersman merged commit 1e21a18 into develop Mar 5, 2018
@arottersman arottersman deleted the arr/safari-hydroshare-link branch March 5, 2018 14:53
@ajrobbins ajrobbins mentioned this pull request Mar 8, 2018
Closed
@rajadain rajadain mentioned this pull request Mar 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajadain rajadain rajadain approved these changes

Assignees

@arottersman arottersman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arottersman @rajadain @hectcastro @kellyi