Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear analysis results on selecting geocoder shape #2705

Merged
merged 1 commit into from
Mar 5, 2018
Merged

Clear analysis results on selecting geocoder shape #2705

merged 1 commit into from
Mar 5, 2018

Conversation

kellyi
Copy link
Contributor

@kellyi kellyi commented Mar 5, 2018 •
edited
Loading

Overview

This PR clears the analyze results on selecting a shape from the geocoder search bar. We also clear the data catalog, since that seems always to be paired with other similar clearAnalyzeCollection method calls.

Connects #2699

Testing

@kellyi kellyi requested a review from rajadain March 5, 2018 20:44
rajadain
rajadain approved these changes Mar 5, 2018
View reviewed changes
Copy link
Member

@rajadain rajadain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 tested, works well! Nice job including clearDataCatalog() as well.

@rajadain rajadain assigned kellyi and unassigned rajadain Mar 5, 2018
@kellyi
Copy link
Contributor Author

kellyi commented Mar 5, 2018

Thanks for your help with this! Going to merge.

@kellyi kellyi merged commit 8acdfa6 into develop Mar 5, 2018
@kellyi kellyi deleted the ki/clear-analyze-results-on-selecting-geocoder-shape branch March 5, 2018 21:14
@rajadain rajadain mentioned this pull request Mar 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajadain rajadain rajadain approved these changes

Assignees

@kellyi kellyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kellyi @rajadain @hectcastro