Adjust SedAAdjust to 1.5 #2876
Merged
Adjust SedAAdjust to 1.5 #2876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajadain
approved these changes
Jun 25, 2018
There was a problem hiding this comment.
+1 tested. For Little Neshaminy HUC-12, the changes are:
--- LittleNeshaminy_Staging.gms.txt 2018-06-25 10:29:51.000000000 -0400
+++ LittleNeshaminy_Local.gms.txt 2018-06-25 10:57:47.000000000 -0400
@@ -33,8 +33,8 @@
Ld_Residential,0.0,0.15,92,74,90
Md_Residential,0.0,0.52,92,74,100
Hd_Residential,0.0,0.87,92,74,110
-0,1,0,0,1,1,1.4
-1819.8145695364237,1176.648366013072,0.9029520636899657,0.01870216369256344,0.25,0.25
+0,1,0,0,1,1,1.5
+1559.841059602649,1176.648366013072,0.9029520636899657,0.01870216369256344,0.25,0.25
2,1,1,1,1
0.75,0.4099323529411765
2.9,0.4099323529411765Per request in #2824, change the SedNitr multiplier to 8.0
kellyi
force-pushed
the
ki/adjust-sedadjust
branch
from
8f8e847
to
c1afe85
Compare
|
Thanks! Will merge once the tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Per the request in #2824, this PR adjusts the SedAAdjust constant for GWLFE to be 1.5 instead of 1.4.
Connects #2824
Notes
We may have already changed the SedNitr value in this PR -- #2563 -- which changed it from 4.0 to 7.0.The document linked from #2824 requests changing it from 4.0 -> 7.0; however the quote in the issue indicated 6.0. Not certain which value to keep.@mmcfarland confirmed that the new value should be 6.0, so that change was made in 8f8e847
Testing Instructions