MapShed Compare: Window and Scenario Header Row #2921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the Compare View button was only shown for TR-55 projects. Now we show it for both TR-55 and MapShed projects.
Previously the Precipitation Slider was always shown because the input scenarios were always TR-55. Now since we can have MapShed scenarios that do not have precipitation inputs, we guard the slider rendering to only show when there are well defined values backing it.
Since the GWLFE Scenario Item Views will not have maps, but colors instead, we're going to make new ones for them. This prefixes the TR-55 ones with that tag so they are easily distinguished.
This adds a new template and view for GWLFE scenarios that doesn't include a map. It does include a spot for showing a scenario color which will correspond with the charts, to be added in upcoming PRs. The list of modifications shown on hover isn't quite right for MapShed. This will be addressed in #2920.
We add a color out of a list of 32 to every scenario copied. This color will be used to highlight the item in the chart and also in the header row for GWLFE. If there are more than 32 scenarios, we will start reusing the colors. Adding the color to a TR-55 scenario is effectively a no-op.
|
I have this branch up now and it's working well. TR-55 Compare View still works as before and the MapShed compare view works as depicted above! |
|
Thanks for pairing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Enables Compare View for GWLF-E projects. Adds colors for 32 scenarios to be used in the charts. Adds a header row for GWLF-E scenarios that don't have a map, but do have a color badge. The popover works the same as in TR-55, but the modifications aren't listed correctly. That is left for #2920.
Connects #2908
Connects #2912
Connects #2913
Demo
Testing Instructions
bundle