Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add protected lands overlay to layer selector #2975

Merged
merged 1 commit into from Sep 19, 2018
Merged

Add protected lands overlay to layer selector #2975

merged 1 commit into from Sep 19, 2018

Conversation

kellyi
Copy link
Contributor

@kellyi kellyi commented Sep 18, 2018 •
edited

Overview

This PR adds the protected-lands-30m overlay option to the layer selector along with a legend.

Connects #2951
Connects #2952
Connects #2953

Demo

screen shot 2018-09-18 at 11 10 04 am

Testing Instructions

  • get this branch, bundle.sh --vendor, then visit localhost:8000
  • select the "Protected Lands" overlay from the layer selector and verify that

@kellyi kellyi changed the title WIP Add protected lands to layer selector WIP Add protected lands overlay to layer selector Sep 18, 2018
@kellyi kellyi force-pushed the ki/add-protected-lands-to-layer-selector branch from 7aaab8b to 6b8328c Compare September 18, 2018 19:46
@kellyi kellyi changed the title WIP Add protected lands overlay to layer selector Add protected lands overlay to layer selector Sep 18, 2018
@kellyi kellyi force-pushed the ki/add-protected-lands-to-layer-selector branch from 6b8328c to de38ea9 Compare September 18, 2018 20:29
kellyi
kellyi commented Sep 19, 2018
View reviewed changes
src/mmw/mmw/settings/layer_settings.py
'display': 'Protected Lands',
'short_display': 'Protected Lands',
'css_class_prefix': 'protected-lands-30m',
'help_text': '',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know what should be the help text for this overlay?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't. The help text shows up for "related layers" in the Analyze tabs. Since this isn't currently a related layer to any tab, we don't have to worry about this field.

rajadain
rajadain approved these changes Sep 19, 2018
View reviewed changes
Copy link
Member

@rajadain rajadain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 tested. Layer works in zoom levels up to 13, matches the input tif, overzooms correctly, opacity slider works correctly, legend matches specification and layer coloring, and placement in the coverage tab is correct. Great work!

image

src/mmw/mmw/settings/layer_settings.py
'display': 'Protected Lands',
'short_display': 'Protected Lands',
'css_class_prefix': 'protected-lands-30m',
'help_text': '',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't. The help text shows up for "related layers" in the Analyze tabs. Since this isn't currently a related layer to any tab, we don't have to worry about this field.

@rajadain rajadain assigned kellyi and unassigned rajadain Sep 19, 2018
@kellyi
Copy link
Contributor Author

kellyi commented Sep 19, 2018 •
edited

Since this isn't currently a related layer to any tab, we don't have to worry about this field.

Makes sense -- I'm going to remove the help_text key from the layer then. I take that back: going to leave as is. Checking to ensure that "Protected Lands" doesn't inadvertently appear as a related layer anywhere and it doesn't seem to, so it's a no-op just to leave the empty string for that key.

@kellyi
Copy link
Contributor Author

kellyi commented Sep 19, 2018

Thanks for your help with this! Going to merge.

@kellyi kellyi merged commit 8f15718 into develop Sep 19, 2018
@kellyi kellyi deleted the ki/add-protected-lands-to-layer-selector branch September 19, 2018 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajadain rajadain rajadain approved these changes

Assignees

@kellyi kellyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kellyi @rajadain