Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Ulmo to 0.8.5 #3143

Merged
merged 1 commit into from Aug 13, 2019
Merged

Upgrade Ulmo to 0.8.5 #3143

merged 1 commit into from Aug 13, 2019

Conversation

@rajadain
Copy link
Member

rajadain commented Aug 12, 2019

Overview

This version supports the native suds timeout parameter, which obviates the need for an external timeout library that we'd been using so far.

With this upgrade, the get_values call is updated to supply the timeout to suds, and the now extraneous library is removed.

Connects #3083

Demo

image

Notes

There may still be some other errors you encounter. If so, use the same shape / test on staging, and ensure you see the same failures there. If you do, then the failures are not related to the changes in this PR, but instead come from the third-party services we're querying instead.

Testing Instructions

  • Check out this branch

  • Destroy and recreate the app VM

    $ vagrant destroy app && vagrant up app
    
  • Go to :8000/ and pick a shape

  • Go to the Monitor tab search for "water"

  • Switch to the CUAHSI tab and click on any of the results in the sidebar

  • Wait for the values to come in

    • Ensure they do
      • If they fail, ensure they also fail on staging
  • Pick a new result and open it

  • Wait for the first details call to succeed (this brings in the units)

  • Then turn off your local internet to simulate a timeout for the values endpoint (which brings in the numbers)

  • Ensure that the error you see for the timeouts are different from a plain "Error 500 during fetch", as shown in the screenshot above

This version supports the native suds timeout
parameter, which obviates the need for an external
timeout library that we'd been using so far.

With this upgrade, the get_values call is updated
to supply the timeout to suds, and the now extraneous
library is removed.
@rajadain rajadain force-pushed the tt/upgrade-ulmo branch from 72fe80a to 2897ff6 Aug 12, 2019
@rajadain rajadain marked this pull request as ready for review Aug 12, 2019
@rajadain rajadain requested a review from caseycesari Aug 12, 2019
Copy link
Member

caseycesari left a comment

Working as described!

@caseycesari caseycesari assigned rajadain and unassigned caseycesari Aug 13, 2019
@rajadain rajadain merged commit 1a9fe06 into develop Aug 13, 2019
2 checks passed
2 checks passed
default Build finished.
Details
model-my-watershed-pull-requests Build #4083 succeeded in 9 min 7 sec
Details
@rajadain rajadain deleted the tt/upgrade-ulmo branch Aug 13, 2019
@rajadain

This comment has been minimized.

Copy link
Member Author

rajadain commented Aug 13, 2019

Thanks for taking a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.