Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This version supports the native suds timeout parameter, which obviates the need for an external timeout library that we'd been using so far.
With this upgrade, the get_values call is updated to supply the timeout to suds, and the now extraneous library is removed.
Connects #3083
Demo
Notes
There may still be some other errors you encounter. If so, use the same shape / test on staging, and ensure you see the same failures there. If you do, then the failures are not related to the changes in this PR, but instead come from the third-party services we're querying instead.
Testing Instructions
Check out this branch
Destroy and recreate the
app
VMGo to :8000/ and pick a shape
Go to the Monitor tab search for "water"
Switch to the CUAHSI tab and click on any of the results in the sidebar
Wait for the values to come in
Pick a new result and open it
Wait for the first
details
call to succeed (this brings in the units)Then turn off your local internet to simulate a timeout for the
values
endpoint (which brings in the numbers)Ensure that the error you see for the timeouts are different from a plain "Error 500 during fetch", as shown in the screenshot above