Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize DB parameter group #3149

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

rbreslow
Copy link
Contributor

@rbreslow rbreslow commented Aug 22, 2019

Overview

When I tried to update the DataPlane stack in staging, CloudFormation encountered this error:

The following parameters are not defined for the specified group:
auto_explain.log_analyze, idle_in_transaction_session_timeout,
backend_flush_after, checkpoint_flush_after, auto_explain.sample_rate,
bgwriter_flush_after, auto_explain.log_format, auto_explain.log_timing,
force_parallel_mode, auto_explain.log_min_duration, auto_explain.log_triggers,
max_parallel_workers_per_gather, auto_explain.log_buffers,
gin_pending_list_limit, auto_explain.log_nested_statements,
auto_explain.log_verbose, log_replication_commands (Service: AmazonRDS; Status
Code: 400; Error Code: InvalidParameterValue; Request ID:
00280e40-fcac-427e-b913-e1850da4bd56)

This is because CloudFormation tries to update the parameter group family from postgres9.4 to postgres9.6, rather than creating a new parameter group based off of postgres9.6.

This PR parameterizes the DB parameter group name so we don't need to finesse CloudFormation.

Connects #3114

Checklist

  • default.yml is updated to reflect these changes

Testing Instructions

Setup the virtualenv for majorkirby:

python2 -m virtualenv ./env
source ./env/bin/activate
pip install -r requirements.txt

Verify that valid JSON is returned for the DataPlane stack:

./mmw_stack.py launch-stacks \
    --aws-profile mmw-stg \
    --mmw-config-path default.yml \
    --mmw-profile staging \
    --data-plane \
    --print-json

@rbreslow rbreslow self-assigned this Aug 22, 2019
@hectcastro hectcastro changed the base branch from develop to release/1.25.0 August 23, 2019 10:46
Copy link
Contributor

@hectcastro hectcastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hectcastro hectcastro merged commit c4c6cb5 into release/1.25.0 Aug 26, 2019
@hectcastro hectcastro deleted the feature/jrb/parameterize-parameter-group branch August 26, 2019 12:38
rajadain added a commit that referenced this pull request Jan 3, 2022
We have been on 9.6.22 since #3149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants