Fix 1 Square Km Draw Tool #3157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bit of code that generates a 1 square km box from a given point is isolated into a utility function so it can be tested separately. Also add a test that exercises the code with sample values taken from production (where the failure does not occur). The failure is likely due to a subtle change in Lodash behavior caused by the upgrade in 6ac8212.
This was previously done by a dense sequence of Lodash methods, some of which were affected by the Lodash upgrade and had stopped working correctly. Now we make the final array by hand using direct values, foregoing any Lodash functionality. This makes the code easier to read and understand, and the tests pass.
caseycesari
approved these changes
Aug 27, 2019
|
Thanks for verifying! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As a likely effect of the Lodash upgrade, the 1 Square Km draw tool had stopped working correctly. The main functionality is extracted into a utility function and a unit test added for it, with sample values taken from production which doesn't have the bug. Once we have our failing test, the utility function is amended to remove Lodash references in favor of a more direct implementation, which is easier to understand and produces correct results. This restores the draw tool functionality.
Connects #3156
Demo
Testing Instructions
bundle --debug --testsChecklist
./scripts/testem.sh