Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Subbasin Catchment Legend When Not In Subbasin Mode #3160

Merged
merged 1 commit into from Aug 29, 2019

Conversation

@rajadain
Copy link
Member

rajadain commented Aug 28, 2019

Overview

Hides the subbasin legend when not in subbasin mode.

Connects #3121

Demo

Go to subbasin mode:

2019-08-28 14 59 18

The legend works correctly, showing the colors for the selected layer, and remembering the selected layer correctly between catchments:

2019-08-28 14 59 48

Once you exit the catchment view, the legend goes away:

2019-08-28 15 00 33

If you switch scenarios, the legend goes away:

2019-08-28 15 01 05

Testing Instructions

  • Go in to subbasin mode, go in to a HUC-12
  • Turn on a related layer
    • Ensure the legend appears
  • Go back to HUC-12 list
    • Ensure the legend disappears
  • Pick a HUC-12 again
    • Ensure the legend appears
  • Pick / create a new scenario
    • Ensure the legend disappears
Previously the subbasin legend would remain active
outside the catchment view, which was the only view
representing the information that legend corresponded
to. In some cases, it would stay on even after exiting
the subbasin view entirely.

Now it is removed from view whenever the subbasin
catchment mode is inactive.
@rajadain rajadain requested a review from caseycesari Aug 28, 2019
@rajadain rajadain added the WPF label Aug 28, 2019
@caseycesari caseycesari assigned rajadain and unassigned caseycesari Aug 29, 2019
Copy link
Member

caseycesari left a comment

Looks good!

@mmcfarland mmcfarland merged commit 2bd21a7 into release/1.25.0 Aug 29, 2019
2 checks passed
2 checks passed
default Build finished.
Details
model-my-watershed-pull-requests Build #4094 succeeded in 10 min
Details
@mmcfarland mmcfarland deleted the tt/subbasin-hide-legend-on-exit branch Aug 29, 2019
@rajadain

This comment has been minimized.

Copy link
Member Author

rajadain commented Aug 29, 2019

Thanks for taking a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.