Hide Subbasin Catchment Legend When Not In Subbasin Mode #3160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the subbasin legend would remain active outside the catchment view, which was the only view representing the information that legend corresponded to. In some cases, it would stay on even after exiting the subbasin view entirely. Now it is removed from view whenever the subbasin catchment mode is inactive.
|
Thanks for taking a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Hides the subbasin legend when not in subbasin mode.
Connects #3121
Demo
Go to subbasin mode:
The legend works correctly, showing the colors for the selected layer, and remembering the selected layer correctly between catchments:
Once you exit the catchment view, the legend goes away:
If you switch scenarios, the legend goes away:
Testing Instructions