Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NLCD codes. #32

Merged
merged 1 commit into from
May 22, 2015
Merged

Fix NLCD codes. #32

merged 1 commit into from
May 22, 2015

Conversation

jamesmcclain
Copy link
Member

Some NLCD codes were incorrect. "Short grass" is of type 81 [1], "chaparral" is of type 52 [2], "desert" is of type 31 [2], and "tall grass" is of type 21 [1].

[1] http://www.asprs.org/a/publications/pers/2003journal/december/2003_dec_1387-1397.pdf p. 1389
[2] http://www.mrlc.gov/nlcd11_leg.php

'short_grass_prairie': {'nlcd': 95, 'ki': 1, 'cn': {'a': 98, 'b': 98, 'c': 98, 'd': 98}}, # noqa
'desert': {'nlcd': 95, 'ki': 1, 'cn': {'a': 98, 'b': 98, 'c': 98, 'd': 98}}, # noqa
'chaparral': {'nlcd': 52, 'ki': 1, 'cn': {'a': 35, 'b': 56, 'c': 70, 'd': 77}}, # noqa
'tall_grass_prairie': {'nlcd': 85, 'ki': 0.6, 'cn': {'a': 35, 'b': 56, 'c': 70, 'd': 77}}, # noqa XXX
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this XXX indicative of something outstanding to do?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I could not find find solid numbers for type 85. I used the ki from short grass and the curve numbers from "brush in fair condition". I also used similarly imputed event mean concentrations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, let's make a corresponding issue for those then.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured that these cannot be worse than the present values, which are all copies of herbaceous wetland.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, will-do.

@lewfish
Copy link
Member

lewfish commented May 22, 2015

In [1], Tallgrass Prairie maps to Urban/Recreational Grasses which I thought would be code 21 (not 85), since urban_grass is 21 in your implementation. +1, otherwise.

@lewfish lewfish assigned jamesmcclain and unassigned lewfish May 22, 2015
@jamesmcclain
Copy link
Member Author

According to the 1992 classification scheme, 85 is Urban/Recreational Grasses and 21 is Low Intensity Residential. I will double-check.

@mmcfarland
Copy link
Contributor

Our eventual land cover data set will be the NLCD 2011, so prefer that over 1992 classifications if there is a discrepancy.

@jamesmcclain
Copy link
Member Author

I think we may have a few minor issues. According to http://www.mrlc.gov/nlcd11_leg.php , 21 is undeveloped open space, which does sound like a good analogue for urban grass. If that is the case, then code 85 might be undefined.

@jamesmcclain
Copy link
Member Author

In any case, if we are using the 2011 scheme, I think that tall grass needs to be 21 and I also need to make another change to the simple app mapping that to 21 instead of 85.

@jamesmcclain
Copy link
Member Author

Thanks for looking carefully, I appreciate it. Is this consistent with your understanding?

@lewfish
Copy link
Member

lewfish commented May 22, 2015

Yes, looks good.

@jamesmcclain
Copy link
Member Author

Okay, I appreciate it.

Some NLCD codes were incorrect.  "Short grass" is of type 81 [1],
"chaparral" is of type 52 [2], "desert" is of type 31 [2], and "tall
grass" is of type 21 [1].

[1] http://www.asprs.org/a/publications/pers/2003journal/december/2003_dec_1387-1397.pdf p. 1389
[2] http://www.mrlc.gov/nlcd11_leg.php
jamesmcclain pushed a commit that referenced this pull request May 22, 2015
@jamesmcclain jamesmcclain merged commit 94036c8 into WikiWatershed:develop May 22, 2015
@jamesmcclain jamesmcclain deleted the bug/nlcd-codes branch May 22, 2015 17:30
@jamesmcclain jamesmcclain added this to the 2015-06-04 milestone May 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants