Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wds-icons-external-small #373

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix wds-icons-external-small #373

wants to merge 1 commit into from

Conversation

vqbc
Copy link

@vqbc vqbc commented Dec 31, 2019

Remove a mask that causes issues with global footer icons when WDSIcons dev script is imported

@mszabo-wikia
Copy link
Contributor

Hi, can you elaborate a bit on what problem this mask is causing and how it can be reproduced?

Thanks for your contribution :)

@vqbc
Copy link
Author

vqbc commented Jan 16, 2020

The error previously caused the app icons in the global footer to display incorrectly (sorry, I don't think I have a screenshot) when the Dev Wiki WDSIcons script was imported, usually for use in another script. I believe that the issue has been resolved with a temporary measure in the script in question, but fixing the svg icon at the source is still a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants