Gallery slideshow: Fix height calculation #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove $container check. This check was broken due to recent changes in skin output (adding mw-parser-output), and was not necessary, as the computation without it is based on $imgContainer, which is also bound by a container. This avoids the height being set to "NaNpx", or the full height of the page. Bug: T196723 Change-Id: I9b4fda9c71502bf749271c55a6945d9f4a4f913e
gitkuba
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove $container check. This check was broken due to
recent changes in skin output (adding mw-parser-output),
and was not necessary, as the computation without it is
based on $imgContainer, which is also bound by a container.
This avoids the height being set to "NaNpx", or the full
height of the page.
Bug: T196723
Change-Id: I9b4fda9c71502bf749271c55a6945d9f4a4f913e