IW-1945 | Global footer #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing on master as well |
xkxd
reviewed
Apr 18, 2019
source/components/GlobalFooter/components/__snapshots__/GlobalFooterWikiaOrg.spec.js.snap
Outdated
Show resolved
Hide resolved
xkxd
reviewed
Apr 18, 2019
source/components/GlobalFooter/components/__snapshots__/BottomBar.spec.js.snap
Outdated
Show resolved
Hide resolved
xkxd
approved these changes
Apr 18, 2019
vforge
previously requested changes
Apr 18, 2019
|
|
||
| const Svg = ({ name, className, ...rest }) => ( | ||
| <svg className={className} {...rest}> | ||
| <use xlinkHref={`#${name}`} /> |
There was a problem hiding this comment.
This will not work unless the images have been added as a sprite - check http://localhost:6060/#!/GlobalFooter
You should use assets directly like so https://wikia.github.io/react-common/#logowikia :
import LogoWikia from '@wikia/react-common/source/assets/LogoWikia';
<LogoWikia height="80" />
There was a problem hiding this comment.
Demo page itself works because on the demo page ALL THE ASSETS are already included on the page.
# Conflicts: # docs/build/1.7afce2f4.js # docs/build/1.a4d7423d.js # docs/build/1.e08e0239.js # docs/build/bundle.faf2c36b.js # docs/index.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wikia-inc.atlassian.net/browse/IW-1945
Porting GlobalFooter component to react,
@Wikia/iwing