New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IW-1945 | Global footer #81
Conversation
Tests are failing on master as well |
source/components/GlobalFooter/components/__snapshots__/GlobalFooterWikiaOrg.spec.js.snap
Outdated
Show resolved
Hide resolved
source/components/GlobalFooter/components/__snapshots__/BottomBar.spec.js.snap
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated snapshots.
LGTM except one issue with it.
|
||
const Svg = ({ name, className, ...rest }) => ( | ||
<svg className={className} {...rest}> | ||
<use xlinkHref={`#${name}`} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not work unless the images have been added as a sprite - check http://localhost:6060/#!/GlobalFooter
You should use assets directly like so https://wikia.github.io/react-common/#logowikia :
import LogoWikia from '@wikia/react-common/source/assets/LogoWikia';
<LogoWikia height="80" />
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Demo page itself works because on the demo page ALL THE ASSETS are already included on the page.
# Conflicts: # docs/build/1.7afce2f4.js # docs/build/1.a4d7423d.js # docs/build/1.e08e0239.js # docs/build/bundle.faf2c36b.js # docs/index.html
https://wikia-inc.atlassian.net/browse/IW-1945
Porting GlobalFooter component to react,
@Wikia/iwing