Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataModel for JacksonInnerEntityId is broken #237

Closed
jinang opened this issue Aug 4, 2016 · 3 comments
Closed

DataModel for JacksonInnerEntityId is broken #237

jinang opened this issue Aug 4, 2016 · 3 comments
Assignees

Comments

@jinang
Copy link

jinang commented Aug 4, 2016

JSON data returned from wbgetentities api has additional 'id' string property added. Breaking serialization of JacksonInnerEntityId.

Data extract form https://www.wikidata.org/w/api.php?action=wbgetentities&ids=Q42
"datavalue": { "value": { "entity-type": "item", "numeric-id": 5, "id": "Q5" }

@mkroetzsch mkroetzsch self-assigned this Aug 4, 2016
@mkroetzsch
Copy link
Member

Is it known when this change was made? It seems the dump processing has worked until recently.

@jinang
Copy link
Author

jinang commented Aug 4, 2016

I'm not sure when the change has been made but it must be fairly recent.
I only found out today when my application failed to get any item documents using wbgetentities, due to serialization errors.

mkroetzsch added a commit that referenced this issue Aug 4, 2016
@mkroetzsch
Copy link
Member

The issue is fixed in master now. A new release is still pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants