-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mismatch in PropertyIdValueImpl #27
Comments
Also, the form "Q[1-9]+" does not capture Q20: "Norway". |
It is intended that "0" is not allowed (that's just how things are in Wikibase; no deeper reason I guess). The exceptions text is of course wrong. Will fix. |
Can you please add a documentation statement about the appropriate values (or add a link to the documentation), since there yet seems to be none (at least I didn't find some). |
I extended the documentation in 37be7b7. I think it is generally agreed upon what "positive integer" means. At least I found the same definition in all places I looked. If 0 is included, one usually speaks of non-negative integers. |
I think that will do it. |
There is a mismatch in PropertyIdValueImpl between the exception message and the reason why the exception was thrown:
Is it intentional that no property with the id "P0" is allowed?
The text was updated successfully, but these errors were encountered: