Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wbSearchEntities expose IOException #467

Merged
merged 4 commits into from Dec 5, 2019
Merged

wbSearchEntities expose IOException #467

merged 4 commits into from Dec 5, 2019

Conversation

maxi-w
Copy link
Contributor

@maxi-w maxi-w commented Dec 5, 2019

Throwing IOException in wbSearchEntities instead of catching it. Otherwise its not possible to handle connection errors in programs using the library. Fixes #421 .

wetneb
wetneb approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@wetneb wetneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 84.664% when pulling 3247ac5 on m-wessendorf:master into 685664d on Wikidata:master.

@wetneb wetneb merged commit 1b6fabe into Wikidata:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wetneb wetneb wetneb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WikibaseDataFetcher does not expose IOException
3 participants
@maxi-w @coveralls @wetneb