Reader for web-API Json into the WDTK data model #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
June 12, 2014 20:17
Also: setup work.
Added support for Labels and Descriptions
Streamlined tests.
Fixed Typo in class name of "TestItemDocument" Moved structuram comparision of Json strings in seperate class.
Speedtest.
Organized classes in a nicer package structure. Reduced code replication. Created a test suite for convenience. Introduced property (de)serialization
added 6 commits
August 9, 2014 16:57
Enabled Jackson to distinguish between Item- and PropertyDocumentImpl on its own.
Intermediate commit - nothing fully functional to see here. Note changes made to existing file for supporting the handling of JSON dumps!
appropriate processor.
Conflicts: wdtk-datamodel/pom.xml Merging master for changed handling of interface overridden methods
|
What is the status of this? Travis indicates an error. We should get this merged soon (the format has changed recently). |
|
I am also getting errors on my machine when I try to compile this. Some required packages seem to be missing, and possibly also some dependencies. |
|
Not sure what the reason was, but it seems to work now after my recent merge of master. |
Main changes: * Distinguish "read only" helper classes from those used by Jackson * Simplify several type conversion methods * Removed helper classes that did not do anything special and used standard datamodel implementations instead * A lot of additional documentation * Removed Helper; put its methods closer to where they are used * Removed some constant definitions that occurred in two classes with the same values
JUnit is well prepared to deal with exceptions and report errors in a useful way. No need for code to do anything else there.
The termed document's method setSiteIri() can be used after JSON deserialization.
* Jackson statements are related to documents rather than to subject entities now, to support site IRI injection later * Fixed several issues with the test construction (naming conventions, code structure)
* Order of reference snaks and qualifiers now used * Some ordering happening in toString() to ensure uniform output * Jackson-based Snaks and ItemIdValues have parent documents to find the site IRI * The Jackson factory correctly sets all data (including mock parent documents where needed) * Some missing toString/equals/hashCode added
mkroetzsch
added a commit
that referenced
this pull request
Sep 30, 2014
Full support for reading API-based JSON format
This was referenced Sep 30, 2014
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a first preview of the upcoming implementation of the (de)serialization code for the "external" web-API json.
There are still some known TODOs:
Please take a quick look at it or feed it some API Json and see if it works. (If not tell me the entityId of the document.)