Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of inconsistently used $warning-color #24

Merged
merged 4 commits into from
Aug 10, 2017

Conversation

simon04
Copy link
Contributor

@simon04 simon04 commented Aug 10, 2017

The red $warning-color is used for various/four purposes. I propose to replace all usages by a more adequate color:

  • Filter: submit button in contrast primary color
  • SearchBar: change red
  • ResultListItem: light primary color as background
  • ResultListItem: transparent category color as bg

See also https://de.wikipedia.org/wiki/Wikipedia_Diskussion:WikiDaheim#Mein_Feedback_vom_2017-08-29

@reiterbene reiterbene merged commit 833c662 into Wikimedia-Austria:master Aug 10, 2017
@reiterbene
Copy link
Member

I would definetelly remove the check mark from the Fertig button - is moves the text to the left and lets the button look unaligned.

@simon04 simon04 mentioned this pull request Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants