-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for 2023 #45
Update for 2023 #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wiki.py I still need to check on a proper screen
Should the Readme explivitly list the expected .env variables? One is implicitly listed but it is not clear if it is the only one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked through the code and left some comments. haven't tried to spin it up yet though
I guess that it may be helpful to list env variables if there are a lot of them. Now there's only one and it's mentioned where it's relevant. |
Fair enough. Does the program still work fine if the env variable is provided directly but the |
Yes. You can use either. If you have both the value from the command line take precedence.
It raises an exception with the error from Phab's API. It looks like this:
|
@sebastian-berlin-wmse the question about the config.yml is still unresolved
|
@sebastian-berlin-wmse Do you want to check that this still works with #48 (as per your comments there). After that (and the resulting rebase) it should be good to merge. |
Based on changes made in project structure for 2023, including:
than a wikipage. Strategies are no longer included.
doesn't include the numbers.