New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add email alerts on application server errors #42
Add email alerts on application server errors #42
Conversation
83681dc
to
a97e774
Compare
These images were already being published separately: |
ff59e51
to
559481c
Compare
okay, I've reworked our docker-related variable names and verified that this is pushing the correct images to dockerhub when I overwrite staging with it.
and was able to get a working deployment without building anything. I did find that we currently can have problems if we have workflow overruns between commits. I spun my wheels for a while trying to get an environment variable injected into a gh artifact name. I don't have this solved, but basically, we should be able to add a commit sha or action run id into the artifact name. It just doesn't seem to be working as I'd expect based on the documentation. https://github.com/actions/upload-artifact#environment-variables-and-tilde-expansion |
559481c
to
174c7d4
Compare
I think I managed to inject a |
Thanks! That's exactly what I was hoping to accomplish! Maybe the env context is only available to tasks running in a shell? This looks good from the github actions perspective! |
Fat-fingered the close button! |
Before merging this to |
Okay, I deployed a new staging environment with the current staging branch. I updated the project wiki notes as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use project and environment specific email addresses. See inline suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! Thanks for your work!
Description
Added a setting in the production and staging environments that allow sending an email whenever there is an application error.
Rationale
This will help track any errors that may occur in the application.
Phabricator Ticket
T258144
How Has This Been Tested?
TBD
Screenshots of your changes (if appropriate):
N/A
Types of changes
What types of changes does your code introduce? Add an
x
in all the boxes that apply: