Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moi v0.10 #285

Merged
merged 9 commits into from
Feb 19, 2022
Merged

Moi v0.10 #285

merged 9 commits into from
Feb 19, 2022

Conversation

Wikunia
Copy link
Owner

@Wikunia Wikunia commented Feb 6, 2022

Some weird bugs still appear when having double negation with xor.
As an example @constraint(m, !(!(sum(x) > 3) ⊻ (sum(x) >= 2))) this currently fails to produce the right results

@Wikunia Wikunia mentioned this pull request Feb 6, 2022
@Wikunia Wikunia linked an issue Feb 6, 2022 that may be closed by this pull request
@Wikunia
Copy link
Owner Author

Wikunia commented Feb 19, 2022

@hakank do you mind testing this on your problems before I merge it to master?
Thanks in advance!

@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #285 (8c0b68b) into master (170dbe4) will decrease coverage by 0.01%.
The diff coverage is 95.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
- Coverage   97.57%   97.56%   -0.02%     
==========================================
  Files          54       54              
  Lines        4545     4554       +9     
==========================================
+ Hits         4435     4443       +8     
- Misses        110      111       +1     
Impacted Files Coverage Δ
src/ConstraintSolver.jl 98.52% <ø> (ø)
src/constraints/indicator.jl 100.00% <ø> (ø)
src/constraints/linear_constraints.jl 97.35% <ø> (ø)
src/constraints/reified.jl 100.00% <ø> (ø)
src/MOI_wrapper/Bridges/strictly_greater_than.jl 75.00% <50.00%> (ø)
src/MOI_wrapper/MOI_wrapper.jl 95.00% <60.00%> (ø)
src/util.jl 96.37% <70.00%> (ø)
src/MOI_wrapper/util.jl 99.26% <97.22%> (-0.74%) ⬇️
src/MOI_wrapper/Bridges/bool.jl 100.00% <100.00%> (ø)
src/MOI_wrapper/Bridges/complement.jl 97.22% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 170dbe4...8c0b68b. Read the comment docs.

@hakank
Copy link

hakank commented Feb 19, 2022

I've just tested all my 119 models with this branch and found no new issue.

@Wikunia
Copy link
Owner Author

Wikunia commented Feb 19, 2022

Thanks for testing :)

@Wikunia Wikunia merged commit 30f7ade into master Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to MOI v0.10.0
2 participants