Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark Mode for validators #433

Merged
merged 2 commits into from Oct 30, 2020
Merged

Dark Mode for validators #433

merged 2 commits into from Oct 30, 2020

Conversation

abdulbasit75
Copy link
Contributor

@abdulbasit75 abdulbasit75 commented Oct 29, 2020 •
edited

Screenshot_20201029-172557_O-FISH
Screenshot_20201029-172620_O-FISH

  • Fixed Tab text and indicator colors
  • Added drawable ic_error_filled
  • Update blue color for light and dark theme

Related Issue

Fixes #

Checklist:

  • I have read the contributor's guide.
  • I linked an issue in the previous section
  • I have commented on the linked issue
  • I was assigned the linked issue (not required)
  • I have tested the change to the best of my ability against the sandbox or a local build.

Optional items:

  • My change adds new text and requires a change to translations.
  • My change requires a change to the documentation.
  • I have submitted a PR to the documentation repo.
  • I was not able to test... (explain below, e.g. you did not have permissions to test a specific feature)
  • This change depends O-FISH Realm repository changes (explain below)
  • This change depends O-FISH Web repository changes (explain below)

  • Optional: Add any explanations here

  • Optional: Add any relevant screenshots here

@abdulbasit75
- Added function in BaseRepoFragment to show empty field warnings
30244ec 
- Fixed Tab text and indicator colors
- Added drawable ic_error_filled
- Update blue color for light and dark theme
@Sheeri Sheeri self-requested a review October 29, 2020 17:47
Sheeri
Sheeri requested changes Oct 29, 2020
View reviewed changes
Copy link
Collaborator

@Sheeri Sheeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the code changes work, I'm confused as to why you changed around several things . Why not just change ic_error_outline to ic_error_filled (and of course add ic_error_filled.xml)?

There are changes to app/src/main/res/layout/item_crew_member.xml, but the changes just move things around - no actual changes made. Please only commit files that are changed in a meaningful way for the code (I was confused as to why you'd change the crew member layout, and then realized - you didn't).

app/src/main/res/layout/fragment_tabs.xml Show resolved Hide resolved
app/src/main/java/org/wildaid/ofish/ui/activity/ActivitiesFragment.kt Show resolved Hide resolved
app/src/main/java/org/wildaid/ofish/ui/tabs/TabsFragmentHost.kt Show resolved Hide resolved
@Sheeri Sheeri merged commit 57dda41 into WildAid:main Oct 30, 2020
@Sheeri
Copy link
Collaborator

Sheeri commented Oct 30, 2020

Congratulations! 🎉 🙌 🎆 ㊗️

This PR is great and has been merged into the code. Thanks so much for contributing! If you'd like, you can request to work on another issue. We really appreciate your effort!

To claim your O-FISH badge, head on over to the MongoDB Community forums, login, and reply - making sure to link to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sheeri Sheeri Sheeri approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abdulbasit75 @Sheeri