Store country code in Vessel Information page

[nugmanoff]

Hey there! I am happy to contribute to your repository as part of Hacktoberfest 2020

This PR Closes #332

Some rationale behind my changes:

• I renamed image variable to code in CountryPickerData because it is quite because previous name is quite ambiguous and misleading per se. So now variable code basically describes what kind of value it holds (short country code). image variable was used only once when magically retrieving country emoji, and even in that context it makes more sense to write function like flag(for countryCode: String)
• This change basically enabled me to retrieve $0.code directly and assign it to vessel.nationality in binding closure without introducing ambiguity (it'd be less obvious if it was self.vessel.nationality = $0.image, but it'd have worked the same way it does now).
• Also I fixed name of the CountryPickerView.swift file.

[Sheeri]

Hi @nugmanoff - Thanks so much for this PR! We appreciate that you gave your rationale for the things we might say "why did they do that?"

Our team will fully review this by this time on Monday (three business days). Until then, please feel free to work on another issue.

[o-fish-wildaid]

Review PRs

[am-MongoDB]

What's in the PR is good, but there's one another change needed.

When you view an existing report, the country should be mapped back from the (stored) code to the full country name – this is what the view currently looks like, but GB should actually be displayed as United Kingdom

[nugmanoff]

@am-MongoDB thanks for pointing that one out, I missed that! Can you please check the updated revision?

[am-MongoDB]

I tested the latest and the report view seems correct, but it looks like 140 older commits have been dragged into this PR

Could you please try to clean up the PR so that it only contains your changes?

Thanks, Andrew.

[am-MongoDB]

@nugmanoff I'm not a git-guru and so I always keep it simple.

If you can't get your current fork into line, then:
[ ] Take a copy of the files you've changed
[ ] Create a clean fork
[ ] Reapply your changes
[ ] Create a new PR, include fixes #332 and a reference your original PR in the description

Andrew.

[nugmanoff]

@am-MongoDB thanks! but I think I've already fixed the issues

[am-MongoDB]

Thanks @nugmanoff PR merged - thanks!