fix(ShepherdProperties): always load relative to catalina.home
#505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
works on linux with our dev/docker environment. |
naknomum
approved these changes
May 2, 2024
This was referenced May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates ShepherdProperties.loadProperties to load paths relative to the Tomcat install rather than relative to the current working directory. While these are often the same, it is possible that the process will have an arbitrary current working directory, such as when running Tomcat manually or when using the macOS Homebrew service.
Fixes #504.
Changes
System.getProperty("catalina.home")to get the Tomcat install path. This is more reliable than using the CWD.PathAPI is used for resolution.