Remove unneeded wbia call #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naknomum
reviewed
Apr 8, 2024
src/main/webapp/iaLogs.jsp
Outdated
| myShepherd.beginDBTransaction(); | ||
| long startTime=System.currentTimeMillis(); |
There was a problem hiding this comment.
Timer removed in subsequent commit.
naknomum
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves iaResults.jsp page display speed while reducing unnecessary traffic to and burden on WBIA. Wildbook knows when a matching Task is complete but was still sending multiple completion status queries to WBIA per page load for completed tasks, causing significant and unnecessary page load slow downs. This change now checks for Task object completion (either its own completion time is set or all completion times are set for all sub-Task node children) in the database before querying WBIA about Task status. For incomplete tasks, queries are still sent.