Fixes Missing Map Icons #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@naknomum Would love your thoughts on the fix. |
naknomum
reviewed
Apr 18, 2024
| @@ -1293,9 +1294,17 @@ if(CommonConfiguration.showProperty("showCountry",context)){ | |||
| %> | |||
|
|
|||
| marker = new google.maps.Marker({ | |||
| icon: 'https://chart.googleapis.com/chart?chst=d_map_pin_letter&chld=<%=markerText%>|<%=haploColor%>', | |||
| //icon: 'https://chart.googleapis.com/chart?chst=d_map_pin_letter&chld=<%=markerText%>|<%=haploColor%>', | |||
| icon: " ", | |||
There was a problem hiding this comment.
am guessing the space must be needed here (versus just dropping the icon element from the json entirely).
There was a problem hiding this comment.
I believe the space is needed according to some reading I did on this issue. But I also didn't test without it.
naknomum
approved these changes
Apr 18, 2024
|
Thanks to @goddesswarship for a quick QA on a test deployment. Fix looks good there too. |
holmbergius
added a commit
that referenced
this pull request
Apr 23, 2024
Fixes Missing Map Icons # Conflicts: # src/main/webapp/encounters/encounter.jsp
holmbergius
added a commit
that referenced
this pull request
Apr 23, 2024
Fixes Missing Map Icons # Conflicts: # src/main/webapp/encounters/encounter.jsp
holmbergius
added a commit
that referenced
this pull request
Apr 24, 2024
Fixes Missing Map Icons # Conflicts: # src/main/webapp/encounters/encounter.jsp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wildbook color-coded its Google Maps pins using a Google Charts API that was turned off in 2019 yet still kept working until...now-ish. With that API now completely turned off for good, our maps pins are missing.
This is the old call:
icon: 'https://chart.googleapis.com/chart?chst=d_map_pin_letter&chld=<%=markerText%>|<%=colorToUseForMarker%>',
The short-term fix is to replace the icon attribute with a Materials font family character label. This actually adds a bit of diversity in the symbols we can use and ended up being somewhat of an improvement in that we can tweak more of the infill, color, size, and display of the icon.
Longer-term, we need to migrate Marker to AdvancedMarkerElement, but that is a major overhaul.
Tested successfully in Chrome and Firefox.
PR fixes #435
