Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved matchAgainst for manual annotation to use the same logic as … #535

Merged
merged 2 commits into from
May 6, 2024
Merged

Improved matchAgainst for manual annotation to use the same logic as … #535

merged 2 commits into from
May 6, 2024

Conversation

holmbergius
Copy link
Contributor

@holmbergius holmbergius commented May 3, 2024 •
edited

…detector.

PR fixes #276 (part 2)

Changes

  • Encounter.matchAgainst for a manually drawn annot can no longer be set by URL
  • Encounter.matchAgainst for an annotation is now set using the same logic as when an annotation is created by detection...by inspecting IA.json

@holmbergius holmbergius requested a review from naknomum May 3, 2024 23:30
@holmbergius holmbergius self-assigned this May 3, 2024
naknomum
naknomum approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@naknomum naknomum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks legit

@naknomum naknomum merged commit 7dfe356 into add_to_10.1.1 May 6, 2024
2 checks passed
@naknomum naknomum deleted the make-match-against-match-detector-logic branch May 6, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naknomum naknomum naknomum approved these changes

Assignees

@holmbergius holmbergius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@holmbergius @naknomum @TanyaStere42