Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format and cleanup; version verification #628

Merged
merged 2 commits into from
Jul 2, 2024
Merged

format and cleanup; version verification #628

merged 2 commits into from
Jul 2, 2024

Conversation

TanyaStere42
Copy link
Member

verifying that all dependencies are locked to a specific version as well as cleanup of commented out dependencies and configuration duplication that could lead to problems down the road

PR fixes #595

Changes

  • linting
  • cleaned out commented out dependencies
  • cleared out maven compiler configuration that is duplicate of the global project setting
  • cleared out duplicate io.prometheus dependencies

@TanyaStere42 TanyaStere42 marked this pull request as ready for review July 1, 2024 22:00
Copy link
Member

@naknomum naknomum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks to be just cleanup of whitespace, cruft, duplication, etc.

confirmed:

  • compiles with maven
  • deployed war file passes spot checks of functionality

@naknomum naknomum merged commit 13a86dd into master Jul 2, 2024
2 checks passed
@naknomum naknomum deleted the pom-cleanup branch July 2, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pom cleanup: lock all dependencies to a single version
2 participants