Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

950: export collaboration #955

Merged
merged 20 commits into from
Jan 29, 2024
Merged

950: export collaboration #955

merged 20 commits into from
Jan 29, 2024

Conversation

naknomum
Copy link
Member

@naknomum naknomum commented Jan 9, 2024

Allows for an export-type collaboration between users, which sits between view and edit types. Creates necessary API calls to support this. Exporting of data will use this in calculating permissions.

@naknomum naknomum force-pushed the 950_export_collaboration_level branch from 9478a95 to ad5d104 Compare January 9, 2024 00:45
@naknomum naknomum linked an issue Jan 9, 2024 that may be closed by this pull request
@naknomum naknomum self-assigned this Jan 9, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (7f7dd7b) 73.3% compared to head (4bbd27d) 73.3%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #955     +/-   ##
=======================================
- Coverage   73.3%   73.3%   -0.1%     
=======================================
  Files        238     238             
  Lines      23566   23716    +150     
  Branches    4287    4336     +49     
=======================================
+ Hits       17296   17390     +94     
- Misses      5008    5044     +36     
- Partials    1262    1282     +20     
Files Coverage Δ
app/extensions/api/namespace.py 88.1% <100.0%> (ø)
app/modules/encounters/schemas.py 98.2% <100.0%> (ø)
app/modules/individuals/schemas.py 98.1% <100.0%> (ø)
app/modules/notifications/models.py 88.8% <100.0%> (+1.1%) ⬆️
app/modules/sightings/resources.py 77.3% <100.0%> (ø)
app/modules/sightings/schemas.py 100.0% <100.0%> (ø)
app/modules/users/permissions/rules.py 83.7% <100.0%> (+0.1%) ⬆️
app/modules/users/permissions/types.py 100.0% <100.0%> (ø)
app/modules/collaborations/resources.py 80.7% <85.7%> (+0.4%) ⬆️
app/extensions/__init__.py 77.8% <86.3%> (+0.3%) ⬆️
... and 4 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f7dd7b...4bbd27d. Read the comment docs.

@naknomum naknomum force-pushed the 950_export_collaboration_level branch from f9975bd to deb4d53 Compare January 17, 2024 23:34
Copy link

@erinz2020 erinz2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to me

@naknomum naknomum marked this pull request as ready for review January 29, 2024 16:55
@TanyaStere42 TanyaStere42 merged commit 5cfb106 into main Jan 29, 2024
10 of 11 checks passed
@TanyaStere42 TanyaStere42 deleted the 950_export_collaboration_level branch January 29, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

export collaboration
3 participants