Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export permissions fixes #965

Merged
merged 1 commit into from
Feb 2, 2024
Merged

export permissions fixes #965

merged 1 commit into from
Feb 2, 2024

Conversation

naknomum
Copy link
Member

@naknomum naknomum commented Feb 2, 2024

some final fixes

@TanyaStere42 TanyaStere42 added this to the Codex Release 2.2 milestone Feb 2, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7bc9e50) 73.4% compared to head (6de1193) 73.3%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #965     +/-   ##
=======================================
- Coverage   73.4%   73.3%   -0.2%     
=======================================
  Files        242     238      -4     
  Lines      24023   23716    -307     
  Branches    4396    4336     -60     
=======================================
- Hits       17654   17384    -270     
+ Misses      5063    5048     -15     
+ Partials    1306    1284     -22     
Files Coverage Δ
app/extensions/__init__.py 77.8% <100.0%> (ø)

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9b8ee6...6de1193. Read the comment docs.

Copy link
Member

@TanyaStere42 TanyaStere42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@TanyaStere42 TanyaStere42 merged commit 9290ef7 into main Feb 2, 2024
10 of 11 checks passed
@TanyaStere42 TanyaStere42 deleted the export_collab_fix2 branch February 2, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants