Port forge 1.20.1 #125
Port forge 1.20.1 #125
Conversation
…that didn't have them. Also make the press key to get started toast use the actual configured keybinding instead of always saying it is G
| @@ -6,7 +6,7 @@ | |||
| # The name of the mod loader type to load - for regular FML @Mod mods it should be javafml | |||
| modLoader="javafml" #mandatory | |||
| # A version range to match for said mod loader - for regular FML @Mod it will be the forge version | |||
| loaderVersion="[41,)" #mandatory This is typically bumped every Minecraft version by Forge. See our download page for lists of versions. | |||
| loaderVersion="[47,)" #mandatory This is typically bumped every Minecraft version by Forge. See our download page for lists of versions. | |||
| # The license for you mod. This is mandatory metadata and allows for easier comprehension of your redistributive properties. | |||
| # Review your options at https://choosealicense.com/. All rights reserved is the default copyright stance, and is thus the default here. | |||
| license="GPLv3" | |||
There was a problem hiding this comment.
Please update the license to LGPLv3.
There was a problem hiding this comment.
Given the fact it literally hasn't been updated anywhere else on other branches I am going to hold off and let wildfire figure out the decision of this. Since the PR that I had seen doing it never got merged.
|
Could someone make please a Fabric port for 1.20.1? 😊 |
Not needed as any mod that was made for 1.20 can actually run on 1.20.1 in terms of fabric. |
|
I don't know how to change this to not be a draft but I glanced over it and it looks fine to me. |
|
Hitting the ready for review button (which I believe repo owner should be able to see). Though I will point out again that it is currently targeting the forge-1.19.3 branch so we will need to make a new branch and retarget it. Or if you want I could just push it directly, but am unsure what you would want the branch named (in terms of 1.20 or 1.20.1 given it is technically 1.20.1+ this supports) |
|
Ahh gotcha, "forge-1.20.1" will work for a branch name if you wanted to push it directly. |
|
Done, closing this as it now serves little purpose |
Theoretically this might support 1.20, but I didn't bother testing (nor allow it in the version bounds) as I think once two forge PRs I made are merged it would be worth using them to cleanup a couple things in the code that I had to work around. I also bounded it at forge 47.0.1 as for earlier versions forge doesn't render armor enchantment glints properly so I figured it makes sense to require that fix just so that it is less visually obtrusive to people.
Other smaller changes in this PR:
Gwill workOpening this as a Draft for now as I am unsure if we should wait for the two forge PRs and also as there is no 1.20 branch to target yet and I am unsure of the exact naming scheme you want to use for the branch so did not create one.