chore: add unittests for every service #705
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newly added unittests for services:
The remaining 5 untested services require a larger / more encompassing mocking of dependencies but I'll see what I can do.
Specifically the window.service as it seems to essentially be a bridge to the frontend in the backend and it requires mocking parts of the electron module which from my experimentation has proven very difficult to achieve in a decent manner.
Same for the error.service which uses the dialog from electron - I've had no success so far in mocking that.
Feel free to modify any files in this PR but if you plan on changing stuff more drastically I'd appreciate a heads up so as to prevent any git conflicts later on.
Closes #670