Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove core/instructions/val in favor of core/value #22

Merged

Conversation

williamberman
Copy link
Contributor

core/instructions/val is being replaced with the core/value module
some of the non abstract machine + tests were dependent on the core/instructions/val module so removed those as well

the contrib/tests/simple_lang.rs tests were dependent on core/instructions/val so I removed and replaced with contrib/tests/simple_langg.rs tests

also ran cargo fmt :P

@williamberman williamberman changed the title remove instructions val remove core/instructions/val in favor of core/value Jun 16, 2022
@WilfredTA
Copy link
Owner

Thanks for making these changes. I was planning on making some of these only AFTER finishing the implementation of the new 'Value' module (specifically, concrete execution will interpret the terms in the AST of Vals, and symbolic execution will Transpile to the AST offered by z3).

With these changes, it will save a lot of time since this PR brings many pieces up to date with the new value module already.

@WilfredTA WilfredTA merged commit f8fcb9f into WilfredTA:abstract_core Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants