Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix imsharpen docstring #419

Closed
cpaniaguam opened this issue Jun 6, 2024 · 2 comments · Fixed by #421
Closed

Fix imsharpen docstring #419

cpaniaguam opened this issue Jun 6, 2024 · 2 comments · Fixed by #421
Assignees
@cpaniaguam

Comments

@cpaniaguam
Copy link
Member

IceFloeTracker.jl/src/normalization.jl

Line 64 in 3228e61

imsharpen(truecolor_image, lambda, kappa, niters, nbins, rblocks, cblocks, clip, smoothing_param, intensity)

@danielmwatkins
Copy link
Contributor

Is this about fixing the function so that there are keyword arguments? Or which aspects are you aiming to fix?

@cpaniaguam
Copy link
Member Author

@danielmwatkins That line shown above doesn't match the function's signature which changed to include the nondilated landmask as an argument. I just forgot to update it!

@cpaniaguam cpaniaguam self-assigned this Jul 17, 2024
@cpaniaguam cpaniaguam linked a pull request Jul 17, 2024 that will close this issue
Fix imsharpen docstring #421
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpaniaguam cpaniaguam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix imsharpen docstring WilhelmusLab/IceFloeTracker.jl
2 participants
@danielmwatkins @cpaniaguam