Fix toplevel borders #171
Merged
Fix toplevel borders #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Thanks for the PR, I'll look at this within the next couple days :) |
|
going to look deeper into |
|
Sorry for the delay, thanks for the contribution! |
rehanzo
pushed a commit
to rehanzo/swayfx
that referenced
this pull request
Jul 12, 2023
* added check for smart * expose gaps_to_edge * add smart variable
WillPower3309
pushed a commit
that referenced
this pull request
Jul 24, 2023
* added check for smart * expose gaps_to_edge * add smart variable
This was referenced Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added an additional check in
render_view_toplevels(...)for thesmart_borderssetting to fix the issue with transparent borders onsmart_borders onandsmart_borders no_gaps.This should fix some issues mentioned in #135.
It seems you have some plans for reworking the border rendering altogether but as of right now, this is a very simple fix.
Some similar logic is happening in
view_autoconfigure(...)so maybe this can be done more elegantly but I don't have a deep enough understanding of the codebase to do this more gracefully (if that's currently possible).