Move word data processing out of the postprocessing step #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, clients can use the API from other websites.
The intention was that the result score is always 0 if the query is equal to the root word, i.e., if no conjugation was going on. Due to not passing the required parameter (embarrassing) it became undefined and of course JS doesn't complain about this, hence this check simply didn't work. Time for TypeScript? Fixes #122 (can be fixed even better later by looking at the number of affixes or something, but this is fine for now).
Word data that is independent of the user query is now processed when the dictionary file is loaded, on Reykunyu startup, instead of every time the user does a query. Fixes #138.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #138.