Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] fmDNS: Can't add more than 4 A records #575

Closed
5 tasks done
millallo opened this issue Apr 18, 2023 · 2 comments
Closed
5 tasks done

[BUG] fmDNS: Can't add more than 4 A records #575

millallo opened this issue Apr 18, 2023 · 2 comments

Comments

@millallo
Copy link
Contributor

Replace everything between stars with current version of your facileManager and module installations:
fM Version : 4.3.0
fmDNS Version : 5.3.1

  • I have read and understood the contributors guide.
  • I have checked that the bug-fix I am reporting can be replicated, or that the feature I am suggesting isn't already present.
  • I have checked that the issue I'm posting isn't already reported.
  • I have checked that the issue I'm posting isn't already solved and no duplicates exist in closed issues and opened issues
  • I have checked the pull requests tab for existing solutions/implementations to my issue/suggestion.

(BUG | ISSUE) Expected Behavior:
I would like to add more than 4 A records in a zone

(BUG | ISSUE) Actual Behavior:
Only last 4 records in the 'Add Records' block are validated

(BUG | ISSUE) Steps to reproduce:
Add 5 records to the 'Add Records' form and validate them, only the last 1 record is validated.

I think this commit broke the correct behaviour:
34774b6

@WillyXJ
Copy link
Owner

WillyXJ commented Apr 18, 2023

You are correct and thanks for pointing that out. MIssed it in the regression testing.

@WillyXJ
Copy link
Owner

WillyXJ commented Apr 19, 2023

This is now fixed in fmDNS 5.3.2 and later.

@WillyXJ WillyXJ closed this as completed Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants