Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting of record display seems bizarre #81

Closed
bigwillystyle42 opened this issue Mar 28, 2014 · 2 comments
Closed

Sorting of record display seems bizarre #81

bigwillystyle42 opened this issue Mar 28, 2014 · 2 comments
Labels
Milestone

Comments

@bigwillystyle42
Copy link
Contributor

@bigwillystyle42 bigwillystyle42 commented Mar 28, 2014

The display of A records in a forward zone is sorted by their value (IP address) which seems like an odd choice. Most other DNS interfaces will display them in alphabetical order.

CNAMEs are a bit better, but still bizarre. b-h are alphabetical, but are followed by the records that start with 'a'.

I think sorting should work like this:

A - alphabetical by record name (no ip_sort)
CNAME - alphabetical by record name (no ip_sort)
MX - numerically by Priority(?) (yes ip_sort)
TXT - alphabetical by record name (no ip_sort)
SRV - alphabetical by record name (no ip_sort)
PTR - numerically by record name (yes ip_sort)
NS - alphabetically by record value (no ip_sort)

I see the code in zone-records.php, so if the above makes sense I'll try and get you a pull request for the change.

@WillyXJ
Copy link
Owner

@WillyXJ WillyXJ commented Mar 28, 2014

I think I'd rather implement a sort_by field so it's more flexible for all users. I'll tag this for 1.2.

@WillyXJ
Copy link
Owner

@WillyXJ WillyXJ commented Apr 17, 2014

I took your proposed sort orders and made them the default order and then also added the ability for users to choose which column to sort by. This framework is also available for other modules to use.

This will go out in 1.2.

@WillyXJ WillyXJ closed this Apr 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants