New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with closing WinMerge with Esc keyboard key #1052
Comments
First, the setting "Options > General > Close windows with Esc > MDI child window or main window" allows WinMerge to be closed with the Esc key. However, WinMerge can only be closed with the Esc key if there is no MDI child window, such as a file comparison window or folder comparison window. If a file or folder comparison window is displayed, WinMerge will not close with a single click of the Esc key. Under these conditions, you will need to press the Esc key at least twice to close WinMerge. Is your problem that WinMerge no longer closes with a single click of the Esc key? Or is it that WinMerge no longer closes no matter how many times you press the Esc key? |
Hmmm... for years I've been able to close WinMerge with a single click of the
I seem to recall having to do that a long, long time ago, but I happily haven't had to do that in years.
The former. |
If /e is not specified as a command line option, then it is correct behavior that WinMerge will not close after a single Esc key press. Various crash bugs have been fixed in WinMerge 2.16.16. It might be better to allow the option dialog to specify settings equivalent to the /e command line options. |
Certainly a possibility. Thanks.
I think that's an excellent idea. |
in commit 88e8c07, I've added a new option that behaves the same as the /e command line option. |
@sdottaka Wonderful! Thank you! |
I believe I may have stumbled on a little issue with v2.16.16.0:
Since it was made available, I've always used the WinMerge setting:
Options > General > Close windows with Esc > MDI child window or main window
to allow closing WinMerge with a single click of the
Esc
keyboard key.Recently, I started using the
/r
command line option when calling WinMerge from another application (let's call thatApp A
).Without making other changes, I noticed that when calling WinMerge from a different application (let's call it
App B
), theEsc
key no longer exits WinMerge (even though I have not changed the WinMerge settings, and the Settings page still indicatesMDI child window or main window
).I had to add the following command line parameters to the WinMerge call from
App B
as a workaround to this issue:/e /x
The text was updated successfully, but these errors were encountered: